Closed (fixed)
Project:
Vocabulary Index
Version:
5.x-2.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Sep 2009 at 16:24 UTC
Updated:
24 Jul 2013 at 08:42 UTC
In the vocabindex module some of the theme function calls are invalid (vocabindex.view.inc, line 375):
return array('list_items' => $items, 'pager' => theme_pager());
Should be
return array('list_items' => $items, 'pager' => theme('pager', $pager));
And calls to theme_item_list() should be reworked (vocabindex.module, line 297):
$output .= theme_item_list($items, NULL, 'ul', array('id' => 'dynamic-help'));
Should be
$output .= theme('item_list', $items, NULL, 'ul', array('id' => 'dynamic-help'));
So far i've found theme_table, theme_image, theme_pager, theme_item_list calls that should be rewritten.
Maybe they should even be rewritten so that the caching mechanism is theme independent. Currently, if the cache is built up using theme A, the overwritten theme functions for theme B are not taken into consideration (but i'll pop that into a separate issue if you don't mind:).
To reproduce
function theme_pager(... to function garland_pager(...
Comments
Comment #1
xanoGood catch! The caching 'issue' is by design. Aggressive caching caches page content after it's been rendered. If you can't or don't want to use this, you can use normal caching.
Comment #2
xanoAnd it's fixed in the dev version :) Thanks for reporting this bug!
Comment #3
xanoThis needs to be backported to DRUPAL-5--2.
Comment #4
xanoFixed in Drupal-5--2 and some additional invalid theme calls in DRUPAL-6--2 have been fixed as well.
Comment #5
xanoComment #7
xano