In the vocabindex module some of the theme function calls are invalid (vocabindex.view.inc, line 375):

return array('list_items' => $items, 'pager' => theme_pager());

Should be

return array('list_items' => $items, 'pager' => theme('pager', $pager));

And calls to theme_item_list() should be reworked (vocabindex.module, line 297):

$output .= theme_item_list($items, NULL, 'ul', array('id' => 'dynamic-help'));

Should be

$output .= theme('item_list', $items, NULL, 'ul', array('id' => 'dynamic-help'));

So far i've found theme_table, theme_image, theme_pager, theme_item_list calls that should be rewritten.

Maybe they should even be rewritten so that the caching mechanism is theme independent. Currently, if the cache is built up using theme A, the overwritten theme functions for theme B are not taken into consideration (but i'll pop that into a separate issue if you don't mind:).

To reproduce

  1. Copy the default theme_pager() code (http://api.drupal.org/api/function/theme_pager/6) and add it to Garlands template.php
  2. Rename the function theme_pager(... to function garland_pager(...
  3. Change something about the output of the pager so that your change will be easy to recognize
  4. Go to a vocabulary index page with more than 25 tags on it
  5. The change you've applied by overriding theme_pager() will not be visible.

Comments

xano’s picture

Priority: Critical » Normal

Good catch! The caching 'issue' is by design. Aggressive caching caches page content after it's been rendered. If you can't or don't want to use this, you can use normal caching.

xano’s picture

Assigned: Unassigned » xano
Status: Active » Fixed

And it's fixed in the dev version :) Thanks for reporting this bug!

xano’s picture

Status: Fixed » Needs work

This needs to be backported to DRUPAL-5--2.

xano’s picture

Status: Needs work » Fixed

Fixed in Drupal-5--2 and some additional invalid theme calls in DRUPAL-6--2 have been fixed as well.

xano’s picture

Version: 6.x-2.1 » 5.x-2.0

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xano’s picture

Assigned: xano » Unassigned