Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There is a mismatch between the filter option 'Body contains' and the display of the option after selecting it, which results in a duplicate 'contains' in 'body contains contains ...'. I suggest to handle it the same way as the title option, where the option itself is only labelled 'title'.
On the other hand - maybe even better -, both options (title and Body contains) could be labelled '... contains', if the 'contains' is removed from the string displaying the selected option.
Also, for translation purposes, for the new options for 'created after' and 'created before' there should be separate string to display them later such as <strong>%filter_name</strong> is after <strong>%filter_value</strong> and <strong>%filter_name</strong> is before <strong>%filter_value</strong>.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | Hardcopy.PNG | 10.66 KB | FrankT |
Comments
Comment #1
FrankT commentedThere is another issue about the way the date format is displayed after the option is selected: it is always the American format (Jun 1, 2009) but the format should be one that is defined for the website.
Comment #2
nancydruAll good points and will work much easier in the new code I committed which will be the beginning of the 6.x-2.x branch.
Comment #3
nancydruQuestion about the dates, in English it is something like MMM DD, YYYY - HH:MM when using format_date('short'). Is that dash there in all languages? I had thought about that issue, but wasn't sure how the date looks in all languages. I didn't want the time on the display, so I went other than format_date; I knew someone would help me fix it...
Comment #4
nancydruAnother question for non_English speakers: Currently, that text (under "Show only items where") checks for the first case. If it is not the first filter it adds "and" on the front. Can I just do exactly that and avoid a bunch of essentially duplicate code?
Something like:
if ($i > 1) { $text = t('and') . $rest of string; }producing : und Titel enthält xxxx
Comment #5
nancydruI committed a fix, but really need some of those answers.
Comment #6
FrankT commentedHi Nancy,
referring to #3 I had a look at my german installation. Most options for the short medium and long date format under /admin/settings/date-time actually contain a '-' between the date and the time. But there are very few options without a '-', and there is always the option to set a user defined date format.
Isn't there a way to take one of these date formats and to omit the time value (sorry, I'M not a programmer)?
Comment #7
nancydruAny theme can be taken over in D6, but that doesn't really solve this issue. I suspect I will have to add a setting to allow you to specify a format.
Comment #8
FrankT commentedDon't hurry Nancy,
I had a look at the 2.x branch now (it went quicker than expected) and things look fine - see attached hardcopy.
There are two things to be changed: there is a string
<u>and</u>- please omit the u-tags because in translation it causes an error about disallowed HTML - also underline is kind of reserved for links and finally I think it looks even better without.There is another thing: the node status is the only option that is still offered to be chosen, even if it has been chosen before (common to both branches).Comment #9
FrankT commentedMost of the reasons for opening the issue are solved (except the new ones just added), except for one thing: For the date options it is OK as it is currently, but it would be even better if a different translatable string could be offered such as 'is created after ' and 'is created before '.
Thanks for your patience, sorry for the many postings within short time...
Comment #10
nancydruOkay, I'll look at these.
Comment #11
nancydruIs this fixed now?
Comment #12
FrankT commentedThe second paragraph of the opening of this issue is not solved yet (but it's only a minor issue).
Comment #13
nancydruOkay, it's fixed now. I also generated a template. Committed to 6.x-2.x-dev.
Comment #14
nancydru