The module depends on securepages.module but it is not listed in the dependencies. Patch attached.

CommentFileSizeAuthor
#5 535426_securepages_dependency.patch6.63 KBdeviantintegral
securepages.patch463 bytesfgm

Comments

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Needs work

Where did you find that it depends on securepages? Two of the functions from that module were copied in to prevent a dependency.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Needs review

dropbox_securepages_url(), which is probably one of the two functions you mention, uses both securepages_baseurl() and securepages_urlencode().

This being said, I'm not sure why you want to maintain a duplicate/fork of these functions instead of just adding a dependency ?

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Needs work

Ouch - I'm surprised I missed those. I originally had thought it was just the one (plus one small) function that was needed, so a whole module with unrelated admin functionality seemed to be overkill.

Given that it would now be 4 functions, a dependancy does make more sense. I'll be posting a patch which makes the required changes soon.

deviantintegral’s picture

deviantintegral commented
Title: Undocumented dependency » Undocumented dependency on securepages
deviantintegral’s picture

deviantintegral commented
Status: Needs work » Needs review
StatusFileSize
new 535426_securepages_dependency.patch6.63 KB

Here's a patch - could you test it and see how it goes? It seems to be working as expected for me. It will also apply cleanly to the current stable release.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Reviewed & tested by the community

Works just fine on 6.1.3.

deviantintegral’s picture

deviantintegral commented
Status: Reviewed & tested by the community » Fixed

Awesome - committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.