First of all: thanks a lot for a great module, been really helpful so far. I'm hosting a petition on my website www.dragolindesign.be and have translated it in Dutch, tested it out and works great!

However I have a small problem: I set up a user role called 'petition admin' and would like to use this for the actual responsible for the petition to be able to edit the petition details herself. I have enabled the permissions for the petition admin role (administer petition and edit petition), however the 'edit' tab does not show up when she logs in

Additionally I did not enable 'clear petition results' and that tab IS showing up for her ?!

Any suggestions?

----------------

Another confusing thing is when clicking the confirmation link in the email, there is no confirmation message displayed on the website and it takes a bit (probably after cache is cleared) for the signature to show up on the list

----------------

One last issue: I enabled comments (both in content type petition and on the actual petition page) but no comment link is showing up? Would be nice if ppl could have some sort of conversation at the bottom through comments, thx!

----------------

Thanks again for this module, sorry for all the questions, hope you can give some pointers for me here :)

CommentFileSizeAuthor
#12 Commentlink.png43.13 KBgauvain

Comments

gauvain’s picture

gauvain commented

1/ Checking the code, I see that I used some wrong access functions for in the hook_menu for the "clear signature" tab.
You can do the following: remove the "administer petition" from the role "Petition admin".
Currently, "administer petition" is used for "Clear signatures" and "adminster signatures".

Normally, the permission "edit petitions" you give the right to edit all petitions.

2/ It may be due to the webhostel you are using. Do you have a dedicated server? If the response time is too slow, the confirmation function may not be entirely run...
I used to have this problem when using a cheap web hosting solution. But In my currently demo version, I don't have any problem.

3/ Yes there is a problem if you want to display the comment form on another page: the link is not displaying. I have to find out the mistake. I scanned rapidly through the code, but could not find any pbl.

Since I only have a CVS client on my private computer whose keyboard is currently broken, I will not be able to update the code before the end of next week any way.

Dragolin’s picture

Dragolin commented

thanks for your quick reply, I disabled the 'administer petition' for now, though the 'edit petition' is still the same problem, not showing up for her ?!

I'll be patient until you get the means to sort this out! Thx in advance :)

Dragolin’s picture

Dragolin commented

A suggestion:

disable caching for this module by default, now you need to clear cache before you see updates to signatures, which is pretty annoying of course

I now downloaded a small module called 'cache-exclude' to do this, but would be nice to have this standard! :)

Dragolin
www.dragolindesign.be

Dragolin’s picture

Dragolin commented

One other thing: how do I set to retrieve the email addresses from this form as well, right now I don't see them in 'administer signatures' or when I download the list, but on your test-site I see some petitions are able to display the emails - thx in advance!

EDIT: I had to add it in the general petition settings, so nvmd :)

gauvain’s picture

gauvain commented

Thx for all your feedbacks: I will have the time for a deep look at the module tomorrow.

in admin/settings/petition you decide what fields people can have access to when creating a petition.
It is then up to the petition maintainer to decide which fields will display in the signature overview (dangerous, because everybody can see them, except if you choose "no display". The fields that will not be displayed in the overview are still available when you export the results as a csv file.

gauvain’s picture

gauvain commented

I fixed the permission issues in today's release.
Concerning the cache issue, I added a function to empty the cache before rerouting to the result page. Please test and report.

Dragolin’s picture

Dragolin commented

I installed version 1.2 manually as it was not detected as an update, now it says there is an update available: version 1.1

seems some settings are not adjusted :D

Anyway I just tested it and enabling 'edit own petition' still does not give me the tab 'edit petition' on the page ...

gauvain’s picture

gauvain commented

Yes, there is not update function: As there was no big changes, I did not create any. I will next time for clarity reason.
What you say is strange.
I have updated the module on http://petition.blogopa.net/ and if you register as a user, you will be able to create a petition and normally see the edit link....

Dragolin’s picture

Dragolin commented
Version: 6.x-1.1 » 6.x-1.2

I just did the same thing and indeed, my new test-user was able to create and edit his own petition.

However when you enable 'edit petition' it does not allow to edit any other petition, as I expected it would ...

The situation is as following: I (the admin) created the petition, but assigned it to a user (author is now that user), but there is no way I can allow that user to edit the petition now ... not by setting 'edit own petition' because it seems putting that user as author does not change the petition to that user (therefore making it 'own') and if I enable the general 'edit petition' it also does not allow that user to edit anything :)

Dragolin’s picture

Dragolin commented

btw: any chance you could have a look at the comment problem as well? Thx so much!

gauvain’s picture

gauvain commented

It was "edit petition" in the old version, but I changed it to "edit petitions". Please reload the permission page and make sure "edit petitions" is checked.
I re-made some with different users and different access permissions: it works on my development versions...

Concerning the comment issue: I completely forgot about it... I will have a more deeply look this week.

gauvain’s picture

gauvain commented
StatusFileSize
new Commentlink.png43.13 KB

Well, it is strange:
I have tested again with the 1.2 version: the comment link displays normally after the petition form, after I enabled it on admin/content/node-type/petition

See attached screenshot

Dragolin’s picture

Dragolin commented

seems I needed to change my comment settings with my current theme, to 'show under post' instead of 'show on seperate page'

thx :)

gauvain’s picture

gauvain commented
Status: Active » Closed (fixed)

Ok good!
I close this issue