greetings! we ran into an issue on http://store.lullabot.com/ because the module currently hard-codes "http://" for the URL to the JS include from amazon s3.

The attached patch updates the module to use the latest JS file from getsatisfaction and does detection on the current protocol so the proper include is generated . (You can see the patch in action on http://store.lullabot.com/ )

CommentFileSizeAuthor
gsfn.patch2.03 KBwalkah

Comments

flevour’s picture

flevour commented

Hi Walkah,
thanks for sending this patch over.
Is there a reason why you use 2 different calls to drupal_add_js (one inline and one in the footer)?
Keep up the fun,
Francesco

turadg’s picture

turadg commented
Status: Needs review » Reviewed & tested by the community

The footer call is probably for performance, so the widget generation doesn't slow the page load.

In any case, the patch works well. I just tested it, so I'm marking it "tested by the community".

flevour’s picture

flevour commented

Finally got the time to release a 1.2 which includes this patch. See the Changelog for a very surprising change since last release.
Thanks for your contribution,
Francesco

flevour’s picture

flevour commented
Status: Reviewed & tested by the community » Fixed

Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.