I haven't done any deep digging on this issue as I just discovered it, but when using Vertical Tabs with the Admin Module/theme, the spacing in the vertical tabs goes all funky. It's a minor annoyance, but I'd think with the vertical tabs style being in D7 by default, it might need to be looked into.

Attached is a screenshot of my node add interface and the vertical tabs. There is just a lot of extra spacing in the region that doesn't look very awesome, pushing the internal content of the tab to the right of the zone. I'm not sure, it could even be something in the vertical tabs code, but It wasn't looking this way when using my default site theme to add/edit content, so I'm just not positive there.

CommentFileSizeAuthor
#3 admin.patch570 byteskarens
Vertical Tabs Alignment53.72 KBhimerus

Comments

solutiondrop’s picture

solutiondrop commented

I noticed that too, and it seems related to #content ul css within the admin/theme/styles.css file, but I'm not sure what the #content ul part is doing to the margin elsewhere for the slate theme:

Line 37:

#content ul,
#content dl {
  margin:0px 0px 20px;
  }

and

Line 54:

  /* Exclude some from this styling */
  #content ul.admin-list,
  #content ul.admin-list li,
  #content .views-edit-view ul,
  #content .views-edit-view ul li,
  #content form ul,
  #content form ul li,
  #content ul.clear-block,
  #content ul.clear-block li,
  #content div.item-list ul,
  #content div.item-list ul li,
  #content ul.menu,
  #content ul.menu li,
  #content ul.links,
  #content ul.links li {
    padding:0px;
    margin:0px;
    list-style:none;
    }
solutiondrop’s picture

solutiondrop commented

I noticed that too, and it seems related to #content ul css within the admin/theme/styles.css file, but I'm not sure what the #content ul part is doing to the margin elsewhere for the slate theme:

Line 37:

#content ul,
#content dl {
  margin:0px 0px 20px;
  }

and

Line 54:

  /* Exclude some from this styling */
  #content ul.admin-list,
  #content ul.admin-list li,
  #content .views-edit-view ul,
  #content .views-edit-view ul li,
  #content form ul,
  #content form ul li,
  #content ul.clear-block,
  #content ul.clear-block li,
  #content div.item-list ul,
  #content div.item-list ul li,
  #content ul.menu,
  #content ul.menu li,
  #content ul.links,
  #content ul.links li {
    padding:0px;
    margin:0px;
    list-style:none;
    }
karens’s picture

karens commented
Status: Active » Needs review
StatusFileSize
new admin.patch570 bytes

Here's a fix for vertical tabs to undo the problem noted above.

solutiondrop’s picture

solutiondrop commented

Thanks Karen, that fixes the problem.

Jackinloadup’s picture

Jackinloadup commented

Tested the patch on three domains. Fixes problem. Thanks!

yhahn’s picture

yhahn commented
Assigned: Unassigned » yhahn
Status: Needs review » Reviewed & tested by the community

Great, will commit sometime this week.

darrenj1’s picture

darrenj1 commented
Title: Vertical Tabs Layout » Vertical Tabs Layout - patch help
Category: bug » support

Hi, how do you apply a patch?

I placed the file in the module folder but no luck.

Jackinloadup’s picture

Jackinloadup commented

@darrenj1 http://drupal.org/patch/apply

Hope that helps. You will need command line access to your site. (at least thats the only way i know of)

yhahn’s picture

yhahn commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone -- committed.

darrenj1’s picture

darrenj1 commented

thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.