I think it looks quite bad to include the site title in the modal dialog title (which is included in $head_title via the theme file). Let's use just the page title. Maybe we should even add a line of comment here to make this clear?

CommentFileSizeAuthor
#2 modalframe-496056-2.patch794 bytesmarkus_petrux
modaltitle.patch773 bytesgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Btw, this code comes from theme.inc, where $head_title is assembled (primarily from strip_tags(drupal_get_title())).

markus_petrux’s picture

markus_petrux commented
StatusFileSize
new modalframe-496056-2.patch794 bytes

We already have the title available for page template, which is what we override here. So, how about this?

markus_petrux’s picture

markus_petrux commented
Status: Needs review » Fixed

Committed patch in #2 to D6 and D7.

Side note: If we want to add/change more template variables, we can always do it in the preprocess function already present in the module.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Looks good to me, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.