Closed (fixed)
Project:
Menu Node Edit
Version:
6.x-1.0
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 May 2009 at 15:17 UTC
Updated:
3 Jun 2009 at 19:05 UTC
Jump to comment: Most recent file
Comments
Comment #1
agentrickardDid you come to the edit page through a link from the user 'Sections' page or from normal node editing?
Comment #2
agentrickardIs 'top' in this case the Menu top level or a node or menu item?
Comment #3
agentrickardDisregard the above comments. Bug confirmed.
The isseue, actually, seems to be that we are not verifying that a unique menu id is being passed before creating the menu item.
Comment #4
agentrickardHere is a partial patch that prevents this problem.
The issue that remains is that a node can be assigned to more than one menu and can actually have multiple menu items. This feature currently has trouble with that.
The attached patch stops the creation of a new menu item if one already exists, but this is only a partial fix, because it will not allow these editors with limited permissions to move a node from one section to another.
Title change, since the problem is not the _location_ of the menu items, but the fact that we are creating duplicate items when using this form element.
Comment #5
bae22 commentedThanks for the quick response.
I'll test the patch today and let you know how it goes.
Comment #6
bae22 commentedThe patch seems to work.
Slightly confused that when editing a node, it still selects the section level of the node rather than the parent level, but saving it does not create a child page any more.
Comment #7
agentrickardWhat do you mean by parent level?
Comment #8
agentrickardThe parent level bit is unchanged, but the UI is a little tricky. I have cleaned that up some -- notably by collapsing the fieldset and changing the help text if a menu item has already been assigned to a node.
By design, when you first create a node, you must choose its 'parent' section. This then becomes visible in the form during later edits.
When a user with the 'publish to my sections' permission first creates a node, she has the option of _not_ assigning it to a menu section. However, once that item is assigned to a section, only a user who may 'administer menu' may remove it.
Comment #9
agentrickardThere is actually a bug in Menu Node API as well.
Both patches are required.
Comment #10
bae22 commentedJust tested it quickly (it is the end of the work day here in the UK!) and it looks as though it works perfectly.
I will test it thoroughly tomorrow, with Modr8 and Revision Moderation.
Thanks ever so much
Comment #11
agentrickardWell, I have the prototype of this in production use, so I need to squash these ASAP, but (obviously) need confirmation.
Comment #12
bae22 commentedTested it this morning. Seems to work exactly as expected. Also tested it with Revision Moderation module; no problems there either. Can't find any faults.
Comment #13
agentrickardYay!
I am going to commit and roll a 6.x.1.1 of both modules.
Thanks!
Comment #14
agentrickard