Hi all,

First time I'm using this module and I've run into 2 issues...

First Issue: When I install the module and then head over to "Add Taxonomy Treemenu", and I get the following line across the top of the page: Warning: Call-time pass-by-reference has been deprecated in sites/all/modules/taxonomy_treemenu/taxonomy_treemenu.admin.inc on line 840

The line this seems to be referring to is: 

function taxonomy_treemenu_edit_menu_submit($form, &$form_state) {
//pull in menu_edit_menu_submit()
require_once(drupal_get_path('module', 'menu') .'/menu.admin.inc');
Line 840:-->  menu_edit_menu_submit($form, &$form_state);

Second Issue: the only taxonomy I'm able to select under the Branch Selector is related to the forum-related taxonomy Drupal created. I have my own taxonomy that I've created, however that taxonomy isn't actually displayed as an option. Not sure if this is related to issue #1 or not...

Can anyone assist? Please let me know if you need more information.

Thanks!

Comments

Apollo610’s picture

Apollo610 commented

To follow up, I just went into my blocks admin to add a block (unrelated to menu_tree) and got the following warnings:

# user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT menu_name, title FROM menu_custom WHERE menu_name IN () in /sites/all/modules/taxonomy_treemenu/taxonomy_treemenu.module on line 311.
# warning: ksort() expects parameter 1 to be array, null given in /sites/all/modules/taxonomy_treemenu/taxonomy_treemenu.module on line 315.
# warning: Invalid argument supplied for foreach() in /sites/all/modules/taxonomy_treemenu/taxonomy_treemenu.module on line 337.

I'm going to disable and uninstall the module now, but if anyone has any suggestions as to what is causing this I'd be happy to backtest any patches.

rcrowther’s picture

rcrowther commented

Hello,

These seem like very different issues, a little unexpected. Thankyou for providing the lines, this is a big help. And I'm sorry that your initial impressions are a series of rather worrying warnings.

1st issue: That ampersand shouldn't be there. The issue is now fixed. Generally, this is a non-hazardous error, which is why it has escaped development so far. Are you running some sort of debug code?

2nd issue: Missing taxonomy is a puzzle. Can you tell me some of the options you are using (multiple parents etc.)?

Post #1: A valuable bug report. Following the initial problems, you seem to have continued without building a treemenu. It would be useful if you could confirm this situation?

This exposed the lack of a test in the hook code, which is now fixed.

Please could you allow me a couple of days to get the revised code back online.

Rob

Apollo610’s picture

Apollo610 commented

Hi Rob, thanks for the feedback! No worries about the module, we all appreciate the efforts being put into it. :)

As of right now I uninstalled the module and deleted it from my modules directory and am just using a basic navigation menu for the time-being. I'll keep an eye out for when the revised module gets re-released and I'll see if the problems still exist.

Thanks again!

rcrowther’s picture

rcrowther commented
Status: Active » Fixed

Both bugs addressed, believed fixed. Missing taxonomy query re-routed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

stoltoguzzi’s picture

stoltoguzzi commented

using the current 6.x.5.1, enabling the module I got 4 times this message:

Warning: Call-time pass-by-reference has been deprecated in .............taxonomy_treemenu.module on line 1649
Warning: Call-time pass-by-reference has been deprecated in .............taxonomy_treemenu.module on line 1660
Warning: Call-time pass-by-reference has been deprecated in .............taxonomy_treemenu.module on line 1717
Warning: Call-time pass-by-reference has been deprecated in .............taxonomy_treemenu.module on line 2614

?