I'm getting this error when inside the JQuery map-->settings, any one who can to explain to a newb how to add the map hilight jquery plugin to my jquery_plugin.module?

Comments

alex.ihlo’s picture

Status: Active » Closed (fixed)

yeh this was easy to fix, the documentation for the module is in the module itself, and in there it says what to do.

alex.ihlo’s picture

Status: Closed (fixed) » Needs review

BUT, I still can't get mine to work. Everything seems right, and I have a settings area...and even in the settings area, at the top it says your jquery plugin is located here________ or something to that effect. Yet when I go to make an image map out of an image, there is no icon in FCK editor.

WorldFallz’s picture

The fckeditor plugin is totally separate from this module. If you're having a problem with this module (using the example image and code provided in the readme.txt) post back. Sorry, I can't support the fckeditor plugin-- all I can say is that I have it working fine.

WorldFallz’s picture

Status: Needs review » Closed (works as designed)
mastoll’s picture

Just a little bit about how to configure the image map . . .
The "title" attribute becomes the tool tip, correct? Is there a way to insert LINKs in the tool tips?

Thanks!
MAStoll

kristi wachter’s picture

For anyone who finds this issue via search:

Be sure you put

jquery.maphilight.min.js

inside the

jquery_plugin

directory, NOT the jq_maphilight directory.

The documentation says to use the jquery_plugin directory, and the message on the jQuery Map Hilight settings page also mentions that it's looking in jquery_plugin, but it's not too hard to get confused.

mvc’s picture

Category: support » bug
Status: Closed (works as designed) » Active

with all due respect, i do not think it's appropriate for one module to require a patch to another, even if it's just to add a .js file. i've seen modules declare a dependency on a certain version of another module or on a patch currently in progress for another module, but i've never seen a module designed to require a patch in another module. i humbly submit that this is poor form.

this module currently calls jquery_plugin_add() from jquery_plugin, but it would be simple to add a call to drupal_add_js() in this module's own directory. or, better yet, somewhere in /sites/*/libraries.

mvc’s picture

Version: 6.x-1.0-beta1 » 6.x-1.1
WorldFallz’s picture

Version: 6.x-1.1 » 6.x-1.0-beta1

sorry mvc, I'm not sure I understand. No one is requiring a patch for anything in this issue.

As for jquery_plugin support -- that was 'the' plugin module at the time this one was created (and in fact, libraries didn't even exist at that time).

I was tossing around the idea of creating a 6.x-2.x branch and switching to libraries support, but otherwise the d6 version is pretty much maintenance only at this point.

WorldFallz’s picture

Version: 6.x-1.0-beta1 » 6.x-1.1

xpost

mvc’s picture

Status: Active » Needs review
StatusFileSize
new3.28 KB

Installing this module requires changing jquery_plugin, since README.txt says "Extract the jquery.maphilight.min.js file into the jquery_plugin directory". In my opinion any change to the contents of a module's directory is a patch. If I upgrade to a new copy of jquery_plugin, the current contents of that directory will get wiped out (assuming I'm following the best practices listed at http://drupal.org/node/250790) and I will need to go download jquery.maphilight.min.js again in order to make this module work. This is confusing (as shown by the above comments) and unnecessary, but easy to fix.

I appreciate that the D6 version of this module is in maintenance only mode, but I think this is worth commiting to your dev branch, even if it's not worth a new release.

mvc’s picture

Version: 6.x-1.1 » 6.x-1.x-dev
WorldFallz’s picture

Status: Needs review » Active

i do appreciate your view, and VERY MUCH the effort to create a patch, but we're going to have to agree to disagree.

I don't think making this type of change in the same major release branch is a good idea. People often upgrade minor releases without testing, reading anything, or checking it out first, and this will cause their functioning module not to function anymore.

It's also begging for trouble to make changes to a dev branch you don't intend on perpetuating to a release.

i will however, create a new 2.x branch where i will switch from jquery_plugin support to libraries support as well as backport a couple of other changes from the 7.x branch. I should have the dev committed in a day or two.

mvc’s picture

fair enough; it's true that just breaking people's sites would not be popular. people who really care about this could just use my patch until your 2.x branch is ready, as i'm doing on my production server. thanks to you for your ongoing work on this module.

WorldFallz’s picture

awesome-- thanks for understanding. I'm about 90% of the way done, I should have something committed by tomorrow night ;-)

WorldFallz’s picture

Status: Active » Fixed

http://drupalcode.org/project/jq_maphilight.git/commit/837e17b

I don't really have time to maintain a separate branch, so I've just patched the module to check for the plugin as follows:

1. if libraries module is enabled, it will use that.
2. 'sites/all/libraries/jquery.maphilight'
3. in the jq_maphilight module direcoty
4. in the jquery_plugin module directory

WorldFallz’s picture

Status: Fixed » Closed (fixed)

new release rolled