i think formatters for url and path should be real plain, without span tags. for me it's now better to use it with "views - override output".

regards peter

CommentFileSizeAuthor
#6 filefield_imagefield_formatters.patch7.51 KBquicksketch
formatter_real_plain.patch1.25 KBpebosi

Comments

henrrrik’s picture

henrrrik commented

+1

span tags are not helpful in this context.

drewish’s picture

drewish commented

I think the only context they're not helpful in would be RSS feeds. On web pages they're very useful for styling.

henrrrik’s picture

henrrrik commented

Typically yes, but in the case of an URL or filepath that points to an image the typical use would be to wrap it in an <a> or <img> which the default <span> prevents.

drewish’s picture

drewish commented

that's reasonable, in that case i'd say we should add linked and plain versions.

quicksketch’s picture

quicksketch
he/him
commented

This seems like it's a good idea to me also. Drewish what do you mean by "linked versions"? The "Generic files" formatter is pretty close to a file link, other than including an icon also, which people might not really want.

I'm also curious why these formatters are in ImageField at all, shouldn't they be handled by FileField?

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new filefield_imagefield_formatters.patch7.51 KB

I've moved the formatters for "path_plain" and "url_plain" to FileField and removed the surrounding spans as recommended by pebosi. Fortunately it doesn't look like we need an update function for this move, CCK is plenty happy using the formatter wherever it happens to live.

Thanks pebosi for your patch. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.