Closed (fixed)
Project:
Nodewords by Path
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Mar 2009 at 23:23 UTC
Updated:
5 Apr 2009 at 03:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
damienmckennaPatch attached.
Comment #2
damienmckennaThere are actually several additional issues as reported by schema.module:
Going through them:
* Should all columns marked "text" with a fixed length, e.g. nodewords_bypath_rules .path_expr, be changed to varchar or should the length be removed?
* MySQL interprets the 'length' attribute as the 'disp-width', i.e. the display width rather than a hard data storage length. Accordingly, the correct 'size' attribute should be used instead, e.g. 'int:1' should be changed to 'int:tiny' ('type' => 'int', 'size' => 'tiny'). Honestly, the 'int:10' should be just left as 'int'. Please see http://matthom.com/archive/2006/11/28/mysql-integer-columns-and-display-... for an easy-to-follow explanation of this.
Comment #3
damienmckennaThe patch needs to also resolve the other issues from comment #2.
Comment #4
univate commentedI have gone through and checked against the schema module and this should be fixed.