This patch reflects the AHAH philosophy of poll.module, as preached by chx. It works with and without project_issue and degrades fine without JS enabled.

CommentFileSizeAuthor
#2 new.patch6.63 KBnetaustin
#1 new.patch6.41 KBnetaustin
fapi_like_poll.patch6.2 KBnetaustin

Comments

netaustin’s picture

netaustin commented
StatusFileSize
new new.patch6.41 KB

use this one

netaustin’s picture

netaustin commented
StatusFileSize
new new.patch6.63 KB

trying again

netaustin’s picture

netaustin commented
Status: Needs review » Fixed

committed.

heine’s picture

heine commented

Unfortunately this seems to cause #373146: 'Comment Field is required' when clicking the Attach. Should we roll this back?

heine’s picture

heine commented
Status: Fixed » Active

Setting this back to active.

Would a rollback conflict with project_issue? I will test before doing anything of course, but a "Not likely" or "Yes, complete breakdown" is helpful.

netaustin’s picture

netaustin commented
Status: Active » Closed (fixed)

Heine: we did eventually roll back to upload.module behavior, which worked much better once a couple minor issues were solved.