Problem/Motivation

PHPStan 2.3.6 is available, so we can probably get this in for the 12 and 11.5 RCs.

We should update that and any outstanding PHPStan packages for main, 12.0.x, 11.x, and 11.5.x to keep the versions in sync and reduce the instances of baseline conflicts on backports.

Proposed resolution

1) Bump PHPStan to version 2.3.6 and friends to latest available

composer update jangregor/phpstan-prophecy mglaman/phpstan-drupal phpstan/extension-installer phpstan/phpdoc-parser phpstan/phpstan phpstan/phpstan-deprecation-rules phpstan/phpstan-phpunit spaze/phpstan-disallowed-calls

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3639196

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

godotislate created an issue. See original summary.

mondrake made their first commit to this issue’s fork.

mondrake’s picture

Status: Active » Needs review
godotislate’s picture

Status: Needs review » Reviewed & tested by the community

This lgtm. I think we'll need a separate MR for 11.x/11.5.x.

  • catch committed 7508ab92 on 12.0.x
    task: #3639196 Bump PHPStan to version 2.3.6 and friends
    
    By:...

  • catch committed 92e5c3a3 on main
    task: #3639196 Bump PHPStan to version 2.3.6 and friends
    
    By:...
catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main and 12.0.x - had to do a small composer.lock commit conflict on 12.0.x

Moving to 11.x for backport.

godotislate’s picture

Opened https://git.drupalcode.org/project/drupal/-/merge_requests/17853 for 11.x
It was mentioned in #3621326-67: Update to PHPStan 2.2.14 that we may have dropped PHPStan 1 compatibility in 11.x accidentally, so restored it in the MR.

godotislate’s picture

Status: Patch (to be ported) » Needs review

Tests are green.

mondrake’s picture

Status: Needs review » Reviewed & tested by the community

Lgtm

godotislate’s picture

Seemed to cherry-pick fine to 11.5.x, but opened a separate MR just in case: https://git.drupalcode.org/project/drupal/-/merge_requests/17855