Problem/Motivation

The webship-js suite pins webship-js ^2.0.6 and @webship-js/drupal-core-steps ^2.1.0, its cucumber.js is not the scaffold's and the Content editor's password is committed. On a Webship site with Website Starter, 3 of 32 scenarios fail: the blog check looks for page "4" in a pager that is a mini pager, the UIkit showcase pages lost their lightbox, slideshow, slider and cover when their bodies moved to Display Builder (#3625725), and the contact form skips a heading level. One step phrase carries a platform name.

Steps to reproduce

  1. Install a Webship site with the Website Starter site template.
  2. Run LAUNCH_URL=https://<site>.ddev.site npm test: 32 scenarios (3 failed, 29 passed).

Proposed resolution

  • cucumber.js from the webship-js 2.0.12 scaffold with the pack and the users registry (credentials from the environment, CHANGE_ME placeholders, loginWait 3000); webship-js ^2.0.12, @webship-js/drupal-core-steps ^2.2.3.
  • The pager check reads the mini pager; the showcase components and the contact form heading are tagged with the reason until the pages and the form are fixed; the step phrase loses the platform name.
  • tests/README.md with the full install from nothing to a green run and the Test users; a webship-js-test CI job on a site installed from the recipe.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ✅ Automated unit/functional testing coverage
  • ✅ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed ab10fbc0 on 1.0.x
    test: #3639067 Update the webship-js suite for webship-js 2.0.12, with...
rajab natshah’s picture

Issue summary: View changes

Merged in !41, pipeline #1053314.