Problem/Motivation

Installing Drupal CMS with Varbase Starter in a language other than English can stop with an InvalidConfigException. On 1.0.10 with Português (Portugal), canvas.page_region.vartheme_bs5.header asks for a component_version of block.system_branding_block or block.views_exposed_filter_block.search-block_1 that does not exist.

Drupal Canvas versions a block component with a hash that includes the translated block label. When Canvas makes the component before the recipe runs, a non-English site has only the translated version, while the recipe pins the English one. It depends on timing, so a different block can fail on each run. English installs are not affected.

Same bug as The Rightup #3636517, reported there by xpete.

Steps to reproduce

  1. Start the Drupal CMS installer.
  2. Pick Português (Portugal) as the language.
  3. Pick the Varbase Starter site template.
  4. The install stops with the InvalidConfigException above.

Proposed resolution

In recipe.yml, keep the English version of each pinned block component whose label is translated, beside the version Canvas made (simpleConfigUpdate on versioned_properties). This is the fix The Rightup merged in MR !100. Leaving component_version out is not possible, because Canvas requires it in config component trees.

Blocks covered: site branding, breadcrumb, blog latest view block, webform block and the header search exposed filter.

Tested locally: Português (Portugal) and English drush installs finish, and the home page and content pages return 200.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix: MR !93
  • ❌ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ❌ Reviewed by human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Fix the install stopping on a Canvas block component version when the language is not English.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
Status: Active » Needs review

  • rajab natshah committed 091cb159 on 1.0.x
    fix: #3638218 Keep the English Canvas block versions on non-English...
rajab natshah’s picture

Issue summary: View changes
Status: Needs review » Fixed
Issue tags: +varbase_starter-1.0.11

✅ Released in varbase_starter 1.0.11

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.