Problem/Motivation
nightwatch.conf.js at the root of the Webship Project template still carries a test account e-mail address on a domain that is not Webship's: the Content admin account, line 34 of the file on 12.0.x (the same line in the 12.0.3 release). The admin and Authenticated user accounts in the file already use @webship.co.
The template is published on drupal.org and mirrored to github.com/webship/webship-project, so the leftover shows up in public code searches. The Nightwatch configuration itself is no longer the project's test runner (the webship-js suite is, see #3636722), but the file ships with every release.
Steps to reproduce
- Open
nightwatch.conf.json 12.0.x. - Read the
emailvalues of the test accounts underglobals.users.
Proposed resolution
Use @webship.co addresses for every Nightwatch test account in nightwatch.conf.js (same local parts, Webship's domain), and change nothing else in the file. Today that is the Content admin account on line 34 only. One commit, one merge request against 12.0.x.
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ❌ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- task: #3636807 Use Webship addresses for the Nightwatch test accounts
AI-Generated: Yes (issue text)
Comments
Comment #2
rajab natshahComment #4
rajab natshahMerged in https://git.drupalcode.org/project/webship_project/-/merge_requests/14 (ships with the next release)
Comment #6
rajab natshah✅ Released webship_project-12.0.4