Problem/Motivation

The module's functional tests (5 feature files) run on webship-js, with the step definitions and the settings kept in the project itself (cucumber.js, tests/step-definitions/).

The public step pack @webship-js/drupal-core-steps 2.1 (npm, GitHub) now ships, for any Drupal core site:

  • login by handle (verified, with a Honeypot-aware loginWait) and Given I add the testing users from the users registry
  • named administration pages, status messages, listings and operations
  • the media library, CKEditor and access control (I should be denied access to "...")
  • site structure assertions, Layout Builder steps, a selector preset and the complete default settings

Local copies drift from the pack and duplicate its maintenance. In this project:

  • Two custom steps in tests/step-definitions/gherkin.steps.js are ambiguous with the pack: the login by handle (I am a logged in user with the "..." user) and I add the testing users. Both match the same sentences as the pack's, so every such sentence matches two definitions once the pack is loaded. The other five custom steps (the field and button steps, the Ace editor step and the CSS step) are kept.
  • package.json has webship-js ^2.0.0, while the pack declares ^2.0.6 as its peer dependency.
  • composer.json sets minimum-stability to dev, which Composer reads only in the root package.

Related: #3635909 (Node.js 24 and Yarn 4.18.1).

Steps to reproduce

  1. Read cucumber.js and tests/step-definitions/ on the 1.0.x branch.
  2. The custom login step and the testing-users step match the same sentences as the pack's.
  3. Read package.json (webship-js) and the pack's peerDependencies, and minimum-stability in composer.json.

Proposed resolution

The pack's 2.1.0 is on npm.

  1. Add @webship-js/drupal-core-steps (^2.1.0) to the package.json devDependencies and its step glob (node_modules/@webship-js/drupal-core-steps/tests/step-definitions/**/*.js) to cucumber.js, between webship-js's own glob and the project's own. webship-js goes from ^2.0.0 to ^2.0.6.
  2. The users registry in cucumber.js already has the pack's shape (username, email, password, roles, isAdmin); keep it.
  3. Remove the two custom steps the pack now provides (the login by handle and I add the testing users) from tests/step-definitions/gherkin.steps.js; keep the rest.
  4. Add a test:dry script (cucumber-js --dry-run) and a dry run in CI before the browser job, so an undefined or ambiguous step fails early.
  5. Remove minimum-stability from composer.json unless something needs it. Check the Composer and npm constraints against the current releases and name the ones that change in the merge request.
  6. One merge request on the 1.0.x branch from an issue fork, pipeline green, then a release.

AI-Generated: Yes (issue text)

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ✅ Automated unit/functional testing coverage
  • ❌ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • The automated tests run on the @webship-js/drupal-core-steps step pack; CI runs a dry run first.

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 3516a954 on 3636737-drupal-core-steps
    ci: #3636737 Pin Drupal core to 11.4.x-dev in the pipeline
    
    The first...

  • rajab natshah committed 3516a954 on 1.0.x
    ci: #3636737 Pin Drupal core to 11.4.x-dev in the pipeline
    
    The first...

  • rajab natshah committed cb930356 on 1.0.x
    task: #3636737 Use @webship-js/drupal-core-steps 2.1 for the webship-js...
rajab natshah’s picture

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.