Problem/Motivation

Baselined PHPStan L3 errors in namespaces Drupal\Core\Test and Drupal\TestTools are noisy when it comes to prepare code for PHPUnit 13 adoption.

Steps to reproduce

Remove baselined errors for those namespaces and run PHPStan analysis.

Proposed resolution

Fix the errors in this issue to simplify PHPUnit 13 adoption issue.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3636339

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !17735

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +PHPStan-3
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Spot checked with the eye test (wasn't sure how else to review).

Based on the title this seems like it could be a massive MR but seems reasonably scoped, thanks for that.

Changes for core/lib/Drupal/Core/Test/EventSubscriber/FieldStorageCreateCheckSubscriber.php I had to do for a client project running level5 so know that works.

Rest looks good to me at least.

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work

I reviewed these changes and then tested them at higher levels to see if they surface any additional violations. Have provided some suggestions. Feel free to disagree with any of them.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review

Thank you @mstrelan. Your points addressed.