Problem/Motivation
Node.js 20 reached end of life on 30 April 2026, and Drupal core main now requires "node": ">= 24.0" in core/package.json. Vardoc has no engines in package.json or themes/vardoc_theme/package.json on 4.0.x and 5.0.x, so nothing says which Node to use. 4.0.x commits a Yarn Classic yarn.lock, and the 5.0.x CircleCI config installs Node 12.
Node 24 is the LTS line, latest v24.22.2, and it is one of the lines the November 2026 security releases will patch. Pinning the major picks those patches up with no further change. Local systems should use Node.js 24 or 26.
Steps to reproduce
- On 4.0.x or 5.0.x, open
package.jsonandthemes/vardoc_theme/package.json: there is noenginesblock. - On 4.0.x,
yarn.lockis a Yarn Classic lockfile. - On 5.0.x, open
.circleci/config.yml: it installs NodeSourcesetup_12.x.
Proposed resolution
package.jsonandthemes/vardoc_theme/package.jsonget an engines block:"node": ">= 24.0". On both branches.- 4.0.x stays on Yarn Classic: Yarn 4 cannot install the
farbtasticGitHub tarball, which has nopackage.json(Manifest not found). NopackageManageris added. - 5.0.x:
.circleci/config.ymlinstalls NodeSourcesetup_24.x. - 4.0.x:
yarn.lockis removed. On both branches.gitignorenow ignoresyarn.lock,package-lock.jsonandpnpm-lock.yaml, so installs resolve frompackage.json. - Dependency ranges in
package.jsonuse carets, the way Drupal core writes them: exact versions,~and.xranges become^MAJOR.MINOR.PATCH, with no major bump.
AI-Generated: Yes
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ❌ Replace the
farbtasticGitHub tarball, which has nopackage.json: Yarn 4 cannot install it on 4.0.x, andnpm installalready fails on it on 5.0.x with Node 22 (pre-existing) - ❌
themes/vardoc_themeusesgulp-sass4, which pulls innode-sass4.14.1; it does not build on Node 22 or 24, so itsnpm installalready fails on the base branch (out of scope here) - ➖ Automated unit testing coverage
- ➖ Automated functional testing coverage
- ➖ UX/UI designer responsibilities
- ➖ Readability
- ➖ Accessibility
- ➖ Performance
- ➖ Security
- ➖ Developer Documentation
- ➖ User Guide Documentation
- ❌ Reviewed by human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Release notes snippet
- ✅ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Node.js 24 or newer is now required, in the engines and CI.
Issue fork vardoc-3635749
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajab natshahComment #7
rajab natshah✅ Released vardoc-4.1.0