Problem/Motivation

In css/ai-media.admin.css the [aria-current="true"] rule sets box-shadow after the :focus-visible rule with the same specificity. Under Default Admin, keyboard focus on the selected option is invisible. Gin is not affected.

Steps to reproduce

  1. Use Default Admin.
  2. Open a media add form with the Upload or Generate switch.
  3. Tab to the selected option.

Proposed resolution

Add a combined [aria-current="true"]:focus-visible rule carrying both the bar and the ring.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release

User interface changes

  • Before (1.0.x): the focused, selected option shows no focus ring (Default Admin).
     the focused, selected option shows no focus ring (Default Admin).
  • After: the selected bar and the focus ring show together.
     the selected bar and the focus ring show together.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A

AI-Generated: Yes

Issue fork ai_media-3634869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new61.64 KB
new61.86 KB

  • rajab natshah committed 2545f53c on 1.0.x
    fix: #3634869 Keep the focus ring on the selected Upload or Generate...
rajab natshah’s picture

Issue summary: View changes
Status: Active » Fixed
Issue tags: +ai_media-1.0.0-rc1

✅ Released ai_media-1.0.0-rc1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.