Problem/Motivation

The module stylesheet reads Default Admin's variables, then Gin's, then falls back to hard-coded colors. Claro's variables are never read, so on Claro the switch and the generator form use the fallback values instead of the theme's own, and the radius, spacing and font sizes are fixed numbers in every theme.

Proposed resolution

  • Resolve every value Default Admin, then Gin, then Claro, then a plain fallback that matches Claro's own value.
  • Add the shared radius, spacing, font size and semibold weight variables to the chain.
  • Style only the module's own classes; the rest of the form stays the theme's. The markup keeps the themes' common classes: button, button--small, form-item__description, visually-hidden, gin-new-flag and admin-new-flag.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release

User interface changes

Before, on 1.0.x, and after, in Gin: the same values, now read from the theme. In Default Admin the two are identical as well.

Before:

The Generate with AI form in Gin before the change

After:

The Generate with AI form in Gin after the change

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • The stylesheet reads the admin theme's variables: Default Admin, Gin and Claro.

AI-Generated: Yes

CommentFileSizeAuthor
#3 gin-after.png29.03 KBrajab natshah
#3 gin-before.png29.06 KBrajab natshah

Issue fork ai_media-3634430

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new29.06 KB
new29.03 KB

  • rajab natshah committed c7b992cd on 1.0.x
    task: #3634430 Use the admin theme variables of Default Admin, Gin and...
rajab natshah’s picture

Issue summary: View changes
Status: Active » Fixed
Issue tags: +ai_media-1.0.0-rc1

✅ Released ai_media-1.0.0-rc1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.