Fixed
Project:
Drupal core
Version:
main
Component:
render system
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Oct 2026 at 20:09 UTC
Updated:
10 Nov 2026 at 13:30 UTC
Jump to comment: Most recent
Problem/Motivation
Renderer::doRender() receives the render context as a required argument, but still retrieves and checks it again.
Background
The same lookup was already removed from the access-denied path in #2511330: Deprecate RendererInterface::render()'s sole $is_root_call parameter.
This is a followup to #2511330: Deprecate RendererInterface::render()'s sole $is_root_call parameter.
Proposed resolution
Remove the remaining redundant lookup and check.
Remaining tasks
Review.
User interface changes
None.
Introduced terminology
None.
API changes
None.
Data model changes
None.
Release notes snippet
n/a
Original report
Followup to #2511330: Deprecate RendererInterface::render()'s sole $is_root_call parameter.
Renderer::doRender() receives the render context as a required argument, but still retrieves and checks it again.
The same lookup was already removed from the access-denied path in #2511330: Deprecate RendererInterface::render()'s sole $is_root_call parameter.
Remove the remaining redundant lookup and check.
Issue fork drupal-3633353
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
panchoComment #4
smustgrave commentedThis doesn't contain a proper issue summary.
Comment #5
panchoComment #6
panchoComment #7
smustgrave commentedMuch better! Thank you
Comment #8
alexpottI searched contrib for an alternate renderer implementation that might break if we do this - found nothing (I did not expect to).
Committed and pushed 6c7f1ffe6fa to main. Thanks!