Problem/Motivation

The kernel tests added by #3631914: Page variants save their page template in the theme registry cache and #3631924: Views and the page_layout source invalidate the runtime theme registry cache fake the request start with a manual loadAll(), so they cannot catch an ordering bug across real requests.
Nothing checks that a page-layout or builder page, rendered first after a cache rebuild, leaves the admin theme page intact.

Proposed resolution

One Functional test: rebuild caches, request a page-layout page or the builder, then an admin page, and assert the admin theme page markup.
In the same test, read cache.bootstrap after a Display Builder Views page and assert theme_registry:runtime:THEME is still valid.

Remaining tasks

  • Write the test.
  • Check it fails with either fix reverted.

User interface changes

None.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mogtofu33 created an issue. See original summary.

  • mogtofu33 committed b903e93b on 1.0.x
    tests: #3631945 Add a functional test for the theme registry cache...
mogtofu33’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

pdureau’s picture

Status: Fixed » Closed (fixed)