Problem/Motivation

  • 768: the header search button sits on top of the menu toggle (axe target-size, serious).
  • 390: the open search field is mostly hidden behind the header, so typed text is not visible.
  • Tablet and phone: the open search has no reachable close button (its X sat under the toggle).
  • 992 to 1399: the menu wraps and Search drops to a second or third row.
  • /search: the keyword field and Search button stack below 768, and the text button is 22 px tall on phones.

Steps to reproduce

Install Educare, open the front page at 390, 768 and 1200 wide, open the header search and type.

Proposed resolution

Follow the VBE Stylesheet navbar (header-mobile, header-desktop, menu-dropdown):

  • The menu collapses into the toggle below 1200 (xl). The design has no tablet frame, so tablet uses the mobile variant.
  • Header line below 1200: search and a bare X/hamburger, 24 px icons 24 px apart; the focus ring shows for keyboard focus only.
  • Open menu below 1200: a full-height panel under the header, items at 32 px with a 48 px pitch, parents open their children inline. Focus moves into it, the page behind is inert and does not scroll, and Escape or the X closes it.
  • Search below 1200: field and accent disc on one line, the header grows to hold it, and the search icon turns into the X. From 1200: one magnifier, an underline-only field and the X; 1200 to 1399 shows the icon without its label.
  • Desktop dropdown: opens under the header with 240 px cards, 20 px titles and a navy underline on the open parent.
  • /search: field and button share a row from 576 up; the button gets a 40 px tap target.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ❌ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release
  • ❌ Follow-up: header height and the phone side margin (header section config), desktop link size and gap, and the "Search by keyword..." placeholder still differ from the design.

User interface changes

  • Before: at 768 the search icon sits on the toggle, at 390 the open field is behind the header, and from 992 to 1399 the header takes two or three rows.
  • After: one header row at every width. Tablet and phone follow header-mobile, closed, with search open and with the menu open. Desktop follows header-desktop for the open search and the dropdown; the closed 1440 header is unchanged.

Release notes snippet

  • Fixed the header search on tablet and phone, and kept the header on one row on desktop.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

After, on the test site (Chromium, logged out):

1440, header closed (unchanged).
Educare header at 1440 wide, closed

1440, search open: one magnifier, an underline field and the close button.
Educare header at 1440 wide with the search open

1440, Admissions dropdown open under the header.
Educare header at 1440 wide with the Admissions dropdown open

768, header closed: search and menu toggle side by side.
Educare header at 768 wide, closed

768, menu open with Admissions expanded.
Educare menu open at 768 wide

768, search open; the header grows to hold the field.
Educare header at 768 wide with the search open

390, header closed.
Educare header at 390 wide, closed

390, menu open with Admissions expanded.
Educare menu open at 390 wide

390, search open.
Educare header at 390 wide with the search open

  • rajab natshah committed 55f2a1d2 on 1.0.x
    fix: #3631544 Fix the header search on tablet and phone, and keep the...
rajab natshah’s picture

Status: Active » Fixed
Issue tags: +vartheme_bs5_educare-1.0.4

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.