Problem/Motivation

Since #3613347: Re-use container in kernel tests, testReservedKeywordsForNaming() in core/modules/pgsql/tests/src/Kernel/pgsql/SchemaTest.php has been failing. This is because this change in DriverSpecificSchemaTestBase::testReservedKeywordsForNaming() needs to be applied to pgsql SchemaTest::testReservedKeywordsForNaming():

-    $this->assertEquals(['config', 'select'], $tables);
+    $this->assertEquals(['config', 'key_value', 'select'], $tables);

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3631202

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

godotislate created an issue. See original summary.

godotislate opened merge request !17455

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Reviewed & tested by the community

Drupal\Tests\system\FunctionalJavascript\ThemeSettingsFormTest failure seems unrelated. I’ve seen it fail quite a lot on Sqlite earlier.

  • catch committed 1c8c4651 on main 
    fix: #3631202 PostgreSQL SchemaTest::testReservedKeywordsForNaming()...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 12.0.x-dev
Status: Closed (fixed) » Patch (to be ported)

Re-opening for backport discussion per #3613347: Re-use container in kernel tests.