Problem/Motivation

samlauth_multi_idp replaces the `samlauth.saml` service with `MultiIdpSamlService`, which overrides `reformatConfig()` and uses the raw value:

Steps to reproduce

1. Install samlauth and samlauth_multi_idp.
2. Set the SP entity ID to `[site:base-url]/saml/metadata`.
3. Open `/saml/metadata`. The `entityID` attribute is `[site:base-url]/saml/metadata` instead of `https://example.com/saml/metadata`.

Proposed resolution

Apply the same replacement as samlauth in `MultiIdpSamlService::reformatConfig()`.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 samlauth_multi_idp-sp-entity-id-base-url-token-3630864-1.patch859 bytesjibus

Comments

jibus created an issue. See original summary.

jibus’s picture

jibus commented
Status: Active » Needs review
StatusFileSize
new samlauth_multi_idp-sp-entity-id-base-url-token-3630864-1.patch859 bytes

Patch attached.

jfurnas’s picture

jfurnas commented

@jibus You seem to be using this module pretty regularly, and have contributed several improvements to it already. Would you like to be added as a co-maintainer so you can help maintain the project instead of relying on me to have to patch everything you come across?

jibus’s picture

jibus commented

@jfurnas , yes, sure, happy to help!

  • jibus committed 651bfb71 on 1.0.x 
    fix: #3630864 SP entity ID: [site:base-url] is not replaced
jibus’s picture

jibus commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.