Use Drupal permissions to store language managers rather than the custom variable.

could you post a screen shot of what you're seeing?

same here

really odd... can you disable Internationalization and see if it's conflicting with it? i wonder if it's their query rewriting.

Ah, great thanks for the follow up. Warning if the permissions haven't been granted is a good idea.

It's not calling user_access() or special casing for uid==1. Here's the relevant part of the code that's doing the check:

/**
 * Determine if a user is a manager for a language (or any langauge if none is
 * specified).
 *
 * @param $language String with the language code. If no value is provided the
 *   a check will be made to see if they manage any language.
 * @param $account Drupal user object.
 * @return Boolean
 */
function translation_overview_is_manager($lang_code = NULL, $account = NULL) {
  $management = variable_get('translation_overview_management', array());

  if (is_null($account)) {
    $account = $GLOBALS['user'];
  }

  if (empty($lang_code)) {
    $allowed = array();
    foreach ($management as $lang => $rids) {
      $allowed += array_filter($rids);
    }
    return (boolean) count(array_intersect_key((array) $account->roles, $allowed));
  }
  return (isset($management[$lang_code]) && count(array_intersect_key((array) $account->roles, array_filter((array) $management[$lang_code]))));
}

I think you could easily make an argument either uid==1 should always return true, or we should be calling user_access() which would have the same effect.

Humm... Yeah, I'm actually not sure why I did this as a separate variable rather than using Drupal permissions... I could have been concerned about creating the permissions dynamically. I'm really not sure.

I think doing these as permissions is actually a better way to do it. It lets us drop a bunch of code and make the configuration a lot simpler to setup and understand. This replaces the 'manage translation overview priorities' permission with separate per language manager permissions. The update function will assign the permissions to the roles that are setup to manage.

Did more testing with this and I'm pretty happy. Also rolled in some PHP warning fixes I encountered while testing.

found one bug and decided to pull the PHP fixes out into their own patch.

i'm pretty close to committing this.

committed this to HEAD.