Problem/Motivation
- The module shares the fs_authmap table with other modules and uses the fs_salesforce_auth table. Uninstalling one module can break the other, and the names don't follow the Drupal convention of starting table names with the module name.
- generate_login_link() doesn't start with the module name and can clash with functions from other modules.
- The SFID class name and several class comments don't follow Drupal coding standards, and RestClient calls \Drupal::time() instead of using dependency injection.
- README.txt still describes Drupal 7.

Proposed resolution
- Move data to salesforce_auth_user and salesforce_auth_authmap with an update hook.
- Rename generate_login_link() to salesforce_auth_generate_login_link() and SFID to SalesforceId.
- Inject the time service into RestClient and fix the remaining coding standards issues.
- Replace README.txt with an up-to-date README.md, crediting the Salesforce Suite module.

Comments

vinektiwari created an issue. See original summary.

  • vinektiwari committed d4e3c058 on 9.0.x
    Issue #3629985 by vinektiwari: Use own database tables and follow Drupal...
vinektiwari’s picture

Version: 9.0.1 » 9.0.2
Status: Needs work » Fixed

Released in 9.0.2.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.