Problem/Motivation

Varbase Core 10.1.x requires "drupal/tagify": "~1.0". Varbase 11 builds that still resolved Tagify 1.x began failing at patching after vardot/varbase-patches 11.0.48 switched to the Tagify 2.x patch.

Moving every Varbase consumer to ~2.0 keeps one Tagify patch for all lines. See Vardot/varbase-patches#662.

Steps to reproduce

  1. Open composer.json on the 10.1.x branch: drupal/tagify is held at ~1.0.

Proposed resolution

Require "drupal/tagify": "~2.0" in composer.json. Tagify 2.0.5 supports Drupal ^10.3 || ^11 || ^12.

Release together with vardot/varbase-patches 10.1.x switching its Tagify patch to the 2.x patch (Vardot/varbase-patches#662). Otherwise Varbase 10.1 builds apply the 1.x patch to Tagify 2 and fail.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release varbase_core-10.1.68

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Requires Tagify 2 (drupal/tagify: ~2.0).
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Title: Require Tagify 2 » Update Tagify module from ~1 to ~2

rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Fixed
Issue tags: +varbase_core-10.1.68

✅ Released in varbase_core 10.1.68

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.