Problem/Motivation

For a logged-in editor, opening the Offcanvas Menu draws the panel under the admin Navigation sidebar. Its menu links are covered and cannot be clicked.

Not a z-index ordering mistake. The panel is 1045 and the sidebar 501, but the panel sits inside header[role="banner"], which sticky-header.theme.scss pins at 489 to keep admin chrome on top. That header is a stacking context, so the panel cannot rise past the sidebar. Raising it would re-cover the admin toolbar.

Panel covered by the admin sidebar

Steps to reproduce

  1. Install The Rightup with vartheme_bs5_rightup, the Navigation module and Gin.
  2. Log in as an administrator and open the front page at 1440x900.
  3. Click the header hamburger.

Proposed resolution

Offset instead of restacking: read Drupal's displace offsets so the panel starts clear of the sidebar. They update as the sidebar expands or collapses, and are absent for anonymous visitors, so nothing changes for them.

Also in this MR:

  • All Offcanvas Menu rules moved into the component stylesheet, which SDC attaches only where the component renders. Removes scss/theme/offcanvas-menu.theme.scss, whose library nothing referenced, so it had not loaded since 5dd414e.
  • Selector hardened to .offcanvas-menu__panel.offcanvas.offcanvas-start (0,4,0) so it beats Bootstrap's [dir="rtl"] rule (0,3,0) on specificity, not on load order.
  • Search field fixed in RTL: padding-inline is already logical, and a [dir="rtl"] override was flipping it back, leaving the placeholder under the icon.

Panel clear of the admin sidebar

Verified in a browser

Sidebar expanded, panel starts at 264; collapsed, at 64; tracks live while open; anonymous unchanged at 0; no overflow at 390px.

RTL on an Arabic page, sidebar expanded then collapsed:

RTL, sidebar expanded

RTL, sidebar collapsed

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • The Offcanvas Menu and its backdrop start clear of the admin Navigation sidebar and follow it as it expands or collapses. Nothing changes for anonymous visitors.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • The Offcanvas Menu no longer opens underneath the admin Navigation sidebar, and its search field renders correctly in RTL.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah’s picture

  • rajab natshah committed 0ebbfee5 on 1.0.x
    fix: #3627031 Make the offcanvas menu clear the admin Navigation sidebar