Problem/Motivation

Cache tags were not processed for tokens during per-row tokenization.

Steps to reproduce

  • TBC

Proposed resolution

Run cache tags through tokens

Remaining tasks

  • ✅ File an issue
  • ➖ Addition/Change/Update/Fix
  • ➖ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ Code review by maintainers
  • ➖ Credit contributors
  • ➖ Release notes snippet
  • ❌ Release

User interface changes

  • Tokens added per-row have not previously been run through token processing.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • @todo

Issue fork views_advanced_cache-3625824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

elc created an issue. See original summary.

elc’s picture

elc commented
Version: 3.x-dev » 2.x-dev
Status: Needs work » Patch (to be ported)

Fixed for 3.x in #3582551: Deprecation of per-row tags and caching; D12 support.

Needs to be ported to 2.x.

elc changed the visibility of the branch 2.x-3625822-regex-exclude to hidden.

elc opened merge request !24

elc’s picture

elc commented

Tests are broken due to Twig dependency #3625969: Twig's 3.30 TypeError: Twig\Runtime\EscaperRuntime::escape(): Argument #4 ($autoescape) must be of type bool, null given

  • elc committed 3a7e24f2 on 2.x 
    fix: #3625824 Tags not always tokenized before merge.

By: elc

elc opened merge request !25

  • elc committed 066e73dc on 2.x 
    fix: #3625824 Tags not always tokenized before merge.

By: elc
elc’s picture

elc commented
Assigned: elc » Unassigned
Status: Patch (to be ported) » Fixed

Just ignore the first merge.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.