Problem/Motivation

The "Write lint caches" jobs on the 12.0.x and 11.x branches are consistently failing.

Per discussions with @longwave and @catch on Slack, this likely because not all jobs are configured to run on push, so the caches aren't being warmed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3625788

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

godotislate created an issue. See original summary.

catch’s picture

#3620707: Skip the download caches job on weekly/daily pipelines just landed in main and 12.0.x, although it was to address stale caches never being regenerated, not because they were failing, so not 100% sure it's related.

However if that suddenly makes 12.0.x scheduled runs work, we could try backporting to 11.x first and go from there?

catch’s picture

Title: Fix failing "Write lint caches" jobs on 11.x and 12.0.x » Fix failing "Write lint caches" jobs on 11.x
Version: 12.0.x-dev » 11.x-dev

https://git.drupalcode.org/project/drupal/-/jobs/12438400 just passed on 12.0.x, so moving this to 11.x-only.

catch’s picture

Status: Active » Needs review

There's a lot of difference between the 11.x and main pipelines.

Pushed a commit to prevent the download on daily jobs, left out the other changes because I can't tell if they're applicable or not.

catch’s picture

Well managed not to break the MR pipelines which is more than can be said for some of my YAML attempts, but this should have zero effect on those otherwise.

godotislate’s picture

Status: Needs review » Needs work

Moving to NW for outstanding MR question.

alexpott’s picture

The 12.0.x got fixed by #3620707: Skip the download caches job on weekly/daily pipelines... it was fixed by running spell check again on 12.0.x.

I think the correct fix here is #3631912: Fix spell checking only on main and the write lint caches job as that stays true to the original intent of #3612933: Only run cspell on main and MRs that target main which is to only run spell check on main.

alexpott’s picture

This MR won't fix the problem because it is not addressing the cause - which is cspell not running on 11.x and 11.5.x - it is running on 12.0.x, main and 11.4.x. The fix on #3631912: Fix spell checking only on main and the write lint caches job should result in this being fixed - and it has test evidence from running on the branches with the label to test lint cache warming.

I'd be in favour of closing this ticket as a duplicate of 3631912

godotislate’s picture

Yeah, if we're agreed that #3631912: Fix spell checking only on main and the write lint caches job is a better way to solve the issue (I have no opinion either way), then we can close this as dupe.

alexpott’s picture

Okay we've fixed the cspell... but we still have eslint and stylelint causing issues on 11.x and 11.5.x - let's backport the part of #3620707: Skip the download caches job on weekly/daily pipelines here...

alexpott’s picture

Status: Needs work » Needs review

Actually #3631912: Fix spell checking only on main and the write lint caches job missed the fact that eslint and stylelint are also causing problems because they only run when certain files change. The simplest fix is to ensure they run as part of the daily test.

alexpott’s picture

See https://git.drupalcode.org/project/drupal/-/jobs/12990911 for an example of the new issue due to eslint caching. I think we should be creating the eslint and stylelint caches on the daily builds as it is possible that we have an 11.x only fix that affects files that need to be scanned and the argument is different for spelling.

alexpott changed the visibility of the branch 3625788-fix-failing-write to hidden.

  • catch committed ffdce40b on 11.5.x
    fix: #3625788 Fix failing "Write lint caches" jobs on 11.x
    
    By:...

  • catch committed 1aae1262 on 11.x
    fix: #3625788 Fix failing "Write lint caches" jobs on 11.x
    
    By:...
catch’s picture

Version: 11.x-dev » 11.5.x-dev
Status: Needs review » Fixed

Committing this from needs review because it's trivial and we can't fully test without scheduled runs happening.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.