Problem/Motivation
The project pins @vardot/varbase-e2e at ^2.0.5. 2.0.7 makes the impact gate cumulative, so no serious accessibility violations now also fails on critical, adds a one step full check and an element level rule check, and makes the structural probes skip anything assistive technology cannot reach. Release: varbase-e2e 2.0.7.
The accessibility coverage in tests/features/15-quality is 10 scenarios, and nearly all of them look at the homepage, so a regression on any other public page goes unnoticed.
Steps to reproduce
- Install Varbase 11 from this project template and run the
15-qualitysuite. - 10 accessibility scenarios run, and only the front page is really audited.
Proposed resolution
- Update
@vardot/varbase-e2eto^2.0.7and regenerateyarn.lock. CI runsyarn installand yarn 4 is immutable in CI, so apackage.jsonbump without the lock fails the job. - Rewrite
15-02-accessibility.featureto 34 scenarios: one gate per public page, with the rules that matter pinned by id. - Add
15-05-accessibility-structure.feature, 15 scenarios for the page title, the language attribute, a single h1, heading order, landmarks, the skip link, zoom, control names, ARIA references and roles, and positive tabindex.
49 of 49 scenarios pass on a fresh Varbase 11 install with vartheme_bs5 5.0.4.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ❌ Raise About Varbase, Features, Blog and Contact Us from a level A audit to
no serious accessibility violationsonce the colour contrast of.btn-outline-primarytext on abg-secondary-subtlecard is resolved. About 3.6:1 against the 4.5:1 AA threshold, 2 to 3 nodes per page. Owned by vartheme_bs5 and the recipe content, not by this change. - ❌ Turn
I print the full accessibility checkinto the assertingthe page should pass the full accessibility checkonce the site wide search block has an accessible label.views.view.searchexposes its keyword filter with an empty label and only aSearch by keywordplaceholder, and it ships from thedrupal_cms_searchrecipe, so it affects the Varbase base too. The full check always runs the structural probes, so no audit level avoids it. - ❌ Restore the form field label probe on Contact Us and Blog once that same search label is fixed. It is pinned to
/user/loginfor now. - ❌ Renumber
15-05-accessibility-structure.featureif the unpushed local work that already uses15-04-drimage-images.featuredoes not land. - ✅ Testing to ensure no regression
- ✅ Automated unit/functional testing coverage
- ✅ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Updated @vardot/varbase-e2e to 2.0.7 and widened the automated accessibility coverage from 10 to 49 scenarios across every public page.
Issue fork varbase_project-3625609
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajab natshah✅ Released varbase_project-11.0.10