Problem/Motivation

RightUp carried its own copy of the generic half of the search page: the Content Type facet, the Search result view mode, and the Canvas block components for the results block and the exposed filters. That work now lives in the Varbase Search Base recipe, so the site template should require it instead of duplicating it. Same base-vs-template split we already did for podcasts.

Steps to reproduce

  • Install RightUp on a fresh Varbase 11 or Drupal CMS site.
  • Compare the search config it ships with what drupal/varbase_search_base now provides: the same six config files exist in both.

Proposed resolution

  • Require drupal/varbase_search_base and add it to recipes:.
  • Drop the six duplicated config files it now provides: facets.facet.search_content_type, core.entity_view_mode.node.search_result, and the Canvas block components for the facet, the views block, and the date and results exposed filters.
  • Drop facets and better_exposed_filters from install: and from composer. Varbase Search Base requires and installs both.
  • Keep RightUp's own /search Canvas page, the Category facet, and the news and podcast search displays. Those are the template's design and depend on its own fields.
  • Create the Category facet with a config action instead of a config file, so it is created after search_api.index.content gains category_name. As a config file it was created first, Facets had no query type for it, and a fresh install failed.

On this issue's branch every drupal/varbase* cross-dependency in composer.json stays at its x-dev constraint, for example drupal/varbase_search_base: 1.0.x-dev, not ~1.0.0. That is deliberate: pinning to released constraints belongs to the release issue, not here.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression: a fresh build and a fresh browser install on both Drupal CMS and Varbase 11
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • None. The search page renders the same, from the base recipe instead of the template's own copy.

API changes

  • N/A

Data model changes

  • The Content Type facet and the Search result view mode now come from Varbase Search Base. The Category facet is created by a config action rather than shipped as a config file.

Release notes snippet

  • RightUp now takes the generic search page from the Varbase Search Base recipe instead of shipping its own copy.

Issue fork rightup-3624922

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue tags: +rightup-1.0.0-alpha1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.