Problem/Motivation

RightUp ships its own copy of the podcast content model: the Podcast content type, its eight fields, the form display, the card, full and text_card_medium view displays, and the pathauto pattern. All of it is byte-identical to what Varbase Podcasts Base ships, so two recipes own one content type and a change to the model has to be made twice.

Steps to reproduce

  1. Install the RightUp site template on Drupal CMS.
  2. Compare config/node.type.podcast.yml and the field.field.node.podcast.* files in RightUp with the same files in Varbase Podcasts Base.

Proposed resolution

  • Apply and require drupal/varbase_podcasts_base (~1.0.0), and delete the 13 duplicated configuration files.
  • Keep what belongs to the site template: the podcast-card component, the Canvas templates bound to this theme, the live_feed, search_index and search_result view displays, the Podcasts and Last Call pages, and the demo episodes.
  • Re-apply the one behaviour that does not survive the move as a config action: the base does not exclude podcasts from the search index and this template does. A duplicate node.type.podcast.yml cannot carry it, because the base creates the type first and a recipe leaves existing configuration alone.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • The Podcast content type, its fields, form display and pathauto pattern now come from Varbase Podcasts Base instead of from this recipe. The resulting model is unchanged.

Release notes snippet

  • N/A

Issue fork rightup-3624658

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed a43d5802 on 1.0.x
    feat: #3624658 Take the podcast content model from Varbase Podcasts Base...
rajab natshah’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue tags: +rightup-1.0.0-alpha1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.