Problem/Motivation

config/node.type.podcast.yml declares search_api_exclude in dependencies.module and carries a third_party_settings.search_api_exclude block, but no package in this recipe's chain requires that module: not this recipe, not varbase_content_base, varbase_media_base, varbase_seo_base or varbase_workflow_base. The only provider in the suite is drupal_cms_search, which reaches a site through varbase_starter, a package this recipe does not require.

CI does not show it, because CI installs onto a full Varbase Starter site where the module is present for other reasons.

varbase_blog_base and varbase_news_base, which this content type was adapted from, carry neither the dependency nor the settings block.

Steps to reproduce

  1. On a site that is not Varbase Starter, run composer require drupal/varbase_podcasts_base.
  2. Apply the four base recipes the README names: varbase_content_base, varbase_media_base, varbase_seo_base, varbase_workflow_base.
  3. Apply varbase_podcasts_base. The Podcast episode content type carries an unmet module dependency on search_api_exclude.

Proposed resolution

Drop the dependency and the third-party settings block, matching Varbase Blog Base and Varbase News Base exactly. The alternative, declaring the module (a Composer require plus a recipe.yml install entry), was not chosen because nothing in the recipe uses the feature.

The same branch also adds logo.png, the 512x512 Varbase drop that varbase_blog_base, varbase_news_base and varbase_events_base each ship at the repository root. This was the only base recipe without one.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • The Podcast episode content type no longer declares a module dependency on Search API Exclude, and no longer carries its per-bundle setting.

Release notes snippet

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
Status: Active » Needs review

  • rajab natshah committed f44523a5 on 1.0.x
    fix: #3624656 Drop the search_api_exclude dependency nothing provides
    
rajab natshah’s picture

Status: Needs review » Fixed

Fixed by MR !4 (f44523a) and released in 1.0.0-alpha1: https://www.drupal.org/project/varbase_podcasts_base/releases/1.0.0-alpha1

node.type.podcast.yml no longer names search_api_exclude or carries its settings block, and the repository now ships logo.png.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.