Problem/Motivation

The Live Feed bar renders 37px tall with a 27px row. The design is a 43px bar with a 19px row (VBN Stylesheet, header-desktop 12725:11524).

Four things are off: the bar has no padding of its own, the label sits flush against the ticker instead of 40px from it, the item inherits the 18px body font, and items are spaced by padding rather than the design's 32px gap.

One is worth knowing, because it looks right and is not: the track's min-block-size: 1.35em resolves against that inherited 18px and forces 24px, so the row stays too tall even once the item's own font-size is correct.

Steps to reproduce

Install the RightUp site template and measure the Live Feed bar on the home page.

Proposed resolution

Set the design's size and spacing on the bar itself, so the label, the items and the track's em-based minimum all resolve against 14px.

Measured after the fix: bar 43px, row 19px, label 40px from the ticker, items 32px apart, still scrolling at 60px/s.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ❌ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release

User interface changes

  • The Live Feed bar is a 43px strip with a 19px row, the label 40px from the ticker and the items 32px apart.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • The Live Feed bar now draws at the height the design gives it.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Status: Active » Needs review

  • rajab natshah committed ce2d7d74 on 1.0.x
    fix: #3624640 Draw the Live Feed bar at the height the design gives it
    
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
Status: Needs review » Fixed
Issue tags: +vartheme_bs5_rightup-1.0.0-alpha1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.