Problem/Motivation

Olivero is enabled in the 11.3.0 filled database dump, we can't update core with missing theme. Since default_admin doesn't exist in 11.3.0 the safest option here is probably to change the 11.3.0 dumps to use stark. We can then open a separate issue fro 11.4.0 dumps to use default_admin.

If Claro is set in any database dumps, we should switch that to Stark too at the same time.

Steps to reproduce

Proposed resolution

The default theme in the dumps is now stark.
Also had to add the following for the assertions in UpdatePathTestBaseFilledTest

  • a translation of a block title.
  • a responsive image style

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3623927

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
quietone’s picture

quietone commented
Assigned: Unassigned » quietone

quietone opened merge request !17167

quietone’s picture

quietone commented
Assigned: quietone » Unassigned
Status: Active » Needs review
quietone’s picture

quietone commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Leaning on green tests here. Happy to see that only 1 test had to be updated. So will focus on just claro in the other :)

quietone’s picture

quietone commented
Parent issue: » #3595082: [meta] Tasks to deprecate the Olivero theme
quietone’s picture

quietone commented

I did some checking and the dump before these changes had the translation of the block title in the file. But it did not show up in the interface and thus I added it again. I will be glad to move away from using the dumps when we stop using them. I can't find the issue for that right now.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

#3403649: Rework database update tests so we don't have to ship database dumps in git is the issue to move away from database dumps.

Committed/pushed to main, thanks!

I think we're fine leaving this as-is in 11.x so moving straight to fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 04341944 on main 
    task: #3623927 Remove Olivero from database dumps

By: catch
By:...