Problem/Motivation
The Varbase admin base recipe sets Gin's favicon and logo, Gin Login's logo, and the Navigation logo to files that live in the Varbase profile and the Varbase starter theme. RightUp installs on Drupal CMS, where that profile is not present, so those paths do not resolve.
- Verified values on a fresh RightUp install:
gin.settings favicon.path = profiles/contrib/varbase/images/favicon.icoandgin.settings logo.path = profiles/contrib/varbase/images/varbase-medium-logo-emblem-color.png - Requesting
/profiles/contrib/varbase/images/favicon.icoreturns HTTP 404. - Every admin page therefore emits a failed request. It also surfaces in the functional suite: the ECA workflow modeler bucket (
tests/features/16-eca-workflow-modeler) fails its "no JavaScript errors" check on "Failed to load resource" for that favicon, because the modeler page renders an icon link element pointing at/profiles/contrib/varbase/images/favicon.ico. - The RightUp theme ships its own assets:
themes/contrib/vartheme_bs5_rightup/favicon.icoandthemes/contrib/vartheme_bs5_rightup/logo.svg, both of which return HTTP 200.
Verified on a fresh install: Drupal CMS 2.1.4, Drupal core 11.4.6, RightUp 1.0.x-dev at e2699b0.
Steps to reproduce
mkdir -p my-drupal-cms-rightup cd my-drupal-cms-rightup ddev config --project-type=drupal11 --docroot=web ddev composer create-project drupal/cms ddev composer config minimum-stability dev ddev composer require drupal/rightup:1.0.x-dev ddev drush si -y ../recipes/rightup ddev drush cget gin.settings favicon.path curl -sk -o /dev/null -w '%{http_code}\n' https://my-drupal-cms-rightup.ddev.site/profiles/contrib/varbase/images/favicon.ico
Proposed resolution
In the RightUp recipe's config actions, point Gin and Gin Login at the theme's own assets and the Navigation logo at the default provider, rather than patching the third-party Varbase admin recipe:
gin.settings:favicon.path = themes/contrib/vartheme_bs5_rightup/favicon.ico,favicon.mimetype = image/vnd.microsoft.icon,favicon.use_default = false,logo.path = themes/contrib/vartheme_bs5_rightup/logo.svg,logo.use_default = falsegin_login.settings:logo.path = themes/contrib/vartheme_bs5_rightup/logo.svg,logo.use_default = falsenavigation.settings:logo.provider = default, until the theme ships a square icon suited to the Navigation rail
This removes the 404 from every admin page and unblocks the ECA modeler bucket's JavaScript-error check.
Remaining tasks
- ✅ File an issue
- ❌ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ❌ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ❌ UX/UI designer responsibilities
- ❌ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Update Release Notes
- ❌ Release
User interface changes
- The admin favicon and the Gin and Gin Login logos become the RightUp theme's own.
- The Navigation rail falls back to the default Drupal logo.
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- The admin favicon and the Gin and Gin Login logos now come from the RightUp theme instead of the Varbase profile, so they no longer 404 on a Drupal CMS site.
Issue fork rightup-3622619
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajab natshahReleased in rightup 1.0.0-alpha1.
Comment #6
rajab natshah