Problem/Motivation
The display headings do not match the brand stylesheet (VBN — Stylesheet, Foundation page, 04 - Display):
- Desktop tracking is missing. Desktop/Display/D1 to D6 carry a letter-spacing of -2% (Figma renders D1 at
-1.08pxon 54px). The theme sets none. - There is no mobile display scale. The design specifies Mobile/Display/D1 to D6 as 44 / 36 / 30 / 24 / 20 / 16 px. The theme leaves this to Bootstrap RFS, whose fluid sizes land well below the design on a phone:
.display-1computes to about 33px at 375px against 44px.
Out of scope for #3620731, which covers headings and body styles only.
Steps to reproduce
- Render an element with
class="display-1"on a site using Vartheme BS5 Rightup. - At 1400px, computed
letter-spacingisnormal(design: -0.02em). - At 375px, computed
font-sizeis about 33px (design: 44px).
Proposed resolution
- Add the mobile display steps to the existing
media-breakpoint-down(md)type scale inscss/base/vartheme.base.scss.vartheme.base.cssloads afterbootstrap.base.cssat the same specificity, so these win over RFS. - Add
letter-spacing: -0.02emto.display-1to.display-6atmdand up.emkeeps it at -2% of whatever size resolves.
Builds on the #3620731 branch, because it extends that issue's mobile block.
Measured before and after
Same page and same theme in both halves of each image. The after half is the merge request's own compiled css/base/vartheme.base.css and components/base/root/root.css, loaded after the shipping stylesheets so the cascade matches what the branch would serve. The figure at the right of each row is the computed font-size and letter-spacing read back from the browser, not a design annotation.
Desktop, 1920px. Every step gains -2% tracking. On the 54px .display-1 that computes to -1.08px, which is what the design shows:
![]()
Mobile, 375px. The steps move off RFS onto the design's scale — 44 / 36 / 30 / 24 / 20 / 16px, where RFS resolved .display-1 to 32.96px. Tracking stays normal here, because the design tracks the displays only from md up:
![]()
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ❌ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
Display headings get -2% tracking on desktop and the design's smaller sizes on phones.
API changes
N/A
Data model changes
N/A
Release notes snippet
Display headings now follow the brand stylesheet: -2% letter-spacing on desktop and the mobile display scale on phones.
Issue fork vartheme_bs5_rightup-3622269
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshahOpened !11.
.display-1to.display-6getletter-spacing: -0.02ematmdand up.vartheme.base.cssloads afterbootstrap.base.cssat the same specificity.css/base/vartheme.base.css.The branch builds on #3620731 (!8), so until !8 merges, !11's diff includes its commits; the change specific to this issue is
ce0b02d.On #3620731 (!8), the lead weight is also corrected to the design's Regular 400 (
52d40d2): Figma binds Lead to Body/Regular/Large.Comment #4
rajab natshahComment #6
rajab natshah✅ Released in vartheme_bs5_rightup 1.0.0-alpha1
Comment #8
rajab natshah