Problem/Motivation

Varbase Admin Base 1.0.1 still grants six entity_clone permissions in recipe.yml to three roles, but the Entity Clone module is no longer installed by the recipe. #3621449 removed drupal/entity_clone from composer.json and entity_clone from the recipe install: list, and left the permission grants behind.

Every install that applies this recipe therefore prints three errors:

[error]  Non-existent permission(s) assigned to role "Content editor" (content_editor) were removed. Invalid permission(s): clone node entity.
[error]  Non-existent permission(s) assigned to role "Content Admin" (content_admin) were removed. Invalid permission(s): clone block entity, clone menu_link_content entity, clone node entity, clone taxonomy_term entity, clone taxonomy_vocabulary entity, clone user entity.
[error]  Non-existent permission(s) assigned to role "Site Admin" (site_admin) were removed. Invalid permission(s): clone block entity, clone menu_link_content entity, clone node entity, clone taxonomy_term entity, clone taxonomy_vocabulary entity, clone user entity.

Steps to reproduce

mkdir -p my-drupal-site-varbase_starter && cd my-drupal-site-varbase_starter
ddev config --project-type=drupal11 --docroot=web
ddev composer create-project drupal/cms
ddev composer require drupal/varbase_starter
ddev drush si -y ../recipes/varbase_starter

Reproduced on Drupal CMS 2.1.4, Drupal core 11.3, PHP 8.4, Varbase Starter 1.0.1, Varbase Admin Base 1.0.1. The same 13 lines are still present on the 1.0.x branch.

Proposed resolution

Remove the 13 orphaned - 'clone … entity' lines from recipe.yml, so the permission grants track the temporary removal of Entity Clone:

  • 1 line under user.role.content_editor
  • 6 lines under user.role.content_admin
  • 6 lines under user.role.site_admin

They come back together with the module when Entity Clone has a stable release, on #3621449.

Verified: after this change the same install prints zero errors and zero warnings.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • Removed 13 orphaned clone … entity permission grants from recipe.yml for the Content editor, Content Admin and Site Admin roles. No stored data changes: these permissions were already being dropped at install time.

Release notes snippet

  • Removed the orphaned Entity Clone permission grants left behind when the module was temporarily removed, so applying the recipe no longer prints three "Non-existent permission(s)" errors.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 7ea99776 on 1.0.x
    fix: #3621823 Remove the orphaned Entity Clone permission grants left...
rajab natshah’s picture

Status: Active » Fixed

Released in Varbase Admin Base 1.0.2.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.