Problem/Motivation

The 1.0.x branch is red. One scenario fails:

1) Scenario: Check that the webmaster can access the Entity clone settings
   tests/features/11-content-workflow/11-03-cloning-content-and-entities.feature:8
   Then I should see "Entity Clone Settings"
   locator.waitFor: Timeout 5000ms exceeded.

Entity Clone was temporarily removed from the three base recipes that required it, in Varbase Admin Base #3621449, Varbase Content Base #3621450 and Varbase SEO Base #3621451, because the module has no stable release and a Drupal CMS site template has to resolve on Composer's default minimum-stability: stable. See #3189738.

So the module is no longer installed, /admin/config/system/entity-clone does not exist, and the test that asserts a webmaster can see that page fails. The test is correct about what it checks; what it checks is simply no longer part of Varbase.

The two negative scenarios in the same file still pass, but only because nobody can see a page that is not there. That is not the access control they were written to prove.

This is blocking every merge request on the branch, not only the one that happened to run into it.

Steps to reproduce

  1. Run the 11-content-workflow suite on 1.0.x.
  2. 16 scenarios, 1 fails.

Failing pipeline: 951887 on 1.0.x.

Proposed resolution

Remove tests/features/11-content-workflow/11-03-cloning-content-and-entities.feature.

This removal is temporary, and tracks the module. When Entity Clone has a stable release and goes back into the base recipes, this coverage comes back with it, unchanged.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ✅ Reviewed by a human
  • ✅ Code review by maintainers
  • ✅ Release varbase_starter-1.0.1

User interface changes

  • None.

API changes

  • None.

Data model changes

  • None.

Release notes snippet

  • Temporarily remove the Entity Clone functional testing coverage, following the temporary removal of the module from the base recipes.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
Status: Active » Needs review

  • rajab natshah committed e34eb5f1 on 1.0.x
    fix: #3621553 Temporarily remove the Entity Clone functional testing...
rajab natshah’s picture

Issue summary: View changes
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase_starter-1.0.1