Problem/Motivation

The README's Routes table documents a /node/{node}/canvas/default path ("Edit the shared ContentTemplate default layout"), but the module does not define any such route. canvas_override.routing.yml only defines /node/{node}/canvas, /node/{node}/canvas/reset and the POST-only /node/{node}/canvas/reset/confirm HTMX endpoint. Visiting /node/{node}/canvas/default returns a 404, even as an administrator.

Editing the shared default layout is actually reached through Canvas's own Edit template local task (entity.node.template), whose visibility Canvas Override already gates with the edit canvas default template permissions in CanvasOverrideHooks::menuLocalTasksAlter().

Steps to reproduce

  • Install canvas_override 1.0.x on Drupal 11.4.5 with Canvas 1.10.1 (with the #3567225 patch) and enable it on a content type.
  • As user 1, visit /node/{nid}/canvas/default for a node of that type.
  • Result: 404. Confirmed with Playwright browser testing on plain Drupal core 11.4.5 and Drupal CMS 2.0.

Proposed resolution

Remove the /node/{node}/canvas/default row from the README's Routes table and describe the real path: the Edit template tab provided by Canvas, gated by the edit canvas default template / edit canvas default template for {type} permissions.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ✅ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Reviewed by a human
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release canvas_override-1.0.0

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Fixed the README Routes table: removed the non-existent /node/{node}/canvas/default route and documented the Edit template tab instead.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Active » Needs review

MR !20 removes the non-existent /node/{node}/canvas/default row from the README's Routes table and documents that the shared default layout is edited through Canvas's own "Edit template" tab, gated by the 'edit canvas default template' permissions.

The 404 was verified in-browser on plain Drupal core 11.4.5 and Drupal CMS 2.0.

MR: https://git.drupalcode.org/project/canvas_override/-/merge_requests/20

AI-Generated: Yes (fix authored with Claude Code; reviewed by Rajab Natshah.)

  • rajab natshah committed ec1f3190 on 1.0.x
    docs: #3621472 Remove the non-existent /node/{node}/canvas/default route...
rajab natshah’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
Issue tags: +canvas_override-1.0.0