Problem/Motivation
In recipe.yml of the Varbase Starter site template, varbase_canvas_base is the second entry in the recipes: list, applied 15 positions before varbase_content_base.
The Canvas layer is therefore applied before the content model exists:
varbase_canvas_baseinstalls thecanvasandcanvas_overridemodules.canvas_overridedescribes itself as letting site builders enable per-content Canvas-based layout editing on the full content view mode for selected content types, and it declaresdrupal:nodeanddrupal:fieldas dependencies.varbase_content_baseis the recipe that provides the content structure: it installsnode,field,taxonomy,views,menu_ui,pathand the rest of the content layer.
So a per-content-type feature is applied to a site that has no content types yet, and node and field come in as module dependencies of the Canvas recipe rather than from the recipe that owns the content model. The ordering is being corrected so the Canvas layer applies on top of an existing content model instead of ahead of it.
This is install order only. No configuration content changes.
Steps to reproduce
- Open
recipe.ymlon the 1.0.x branch of Varbase Starter. - Read the
recipes:list:varbase_canvas_baseis 2nd,varbase_content_baseis 17th.
Proposed resolution
Remove - varbase_canvas_base from position 2 and insert it immediately after - varbase_content_base, so the sequence reads:
- varbase_editor_base - varbase_content_base - varbase_canvas_base - varbase_workflow_base
The list stays at 25 entries and nothing else in the file changes. The reordered YAML parses; that is all that has been checked so far.
Apply order only shows up on a clean install, so this needs a fresh-install verification on both bases:
- Fresh install on the Varbase base.
- Fresh install on the Drupal CMS base.
Remaining tasks
- ✅ File an issue
- ❌ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit testing coverage
- ➖ Automated functional testing coverage
- ➖ UX/UI designer responsibilities
- ➖ Readability
- ➖ Accessibility
- ➖ Performance
- ➖ Security
- ➖ Developer Documentation
- ➖ User Guide Documentation
- ❌ Reviewed by human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Release notes snippet
- ❌ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Varbase Canvas Base is now applied after Varbase Content Base, so the Canvas layer is set up on top of an existing content model.
Issue fork varbase_starter-3621018
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajab natshah✅ Released varbase_starter-1.0.0