Problem/Motivation
Varbase 11 used to get six front-end libraries by running scripts/drupal-libraries-sync.js, a Node script that copied files out of node_modules/ into web/libraries/, driven by a drupal-libraries block plus six npm dependencies and a postinstall hook in package.json. That is replaced by Composer packages on Packagist, each required by the module or the varbase_* recipe that actually loads it: vardot/aos 2.3.4, vardot/jquery.fancytree 2.38.5, vardot/ckeditor5-media-embed-drupal 47.6.2, vardot/ace 1.44.0 and vardot/dropzone 5.9.3 (all type: drupal-library, all on Packagist), plus swagger-api/swagger-ui, which drupal/openapi_ui_swagger already required and which only needed an installer path.
The Drupal CMS pre-test job in .gitlab-ci.yml explains its --no-scripts flag with this comment:
# --no-scripts skips the varbase drupal-libraries yarn sync (ace, dropzone, …), # which the news tests do not exercise; the scaffold plugin still runs on # composer install below.
There is no such sync any more, so the comment describes something that no longer exists. A reader following it would look for a yarn sync that is not there, and could reasonably conclude that --no-scripts is what stops the front-end libraries being installed.
Steps to reproduce
- Check out the
1.0.xbranch and open.gitlab-ci.yml. - Find the
--no-scriptscomment in the Drupal CMS pre-test job. - Look for the
drupal-librariesyarn sync it names: it does not exist in Varbase 11 any more.
Proposed resolution
Correct the comment so it says what --no-scripts actually skips now (the project's own composer scripts, which the news tests do not exercise), and state the fact that matters explicitly: the front-end libraries are placed by composer/installers installer paths, which are plugin-driven rather than scripts, so --no-scripts does not stop web/libraries being populated.
Comment-only change. No job, command or flag changes.
Verified on a freshly installed Varbase 11.4.5 site in DDEV with the packages resolved from Packagist and no VCS repositories: 14/14 declared library files present, 10/10 assets HTTP 200, 7/7 Drupal libraries discovered with every asset resolving, status report green, and yarn install succeeds with none of the six npm library packages present.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ✅ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Update Release Notes
- ❌ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Corrected the
--no-scriptscomment in.gitlab-ci.yml: it described a yarn sync that no longer exists, and now states that the front-end libraries are placed by Composer installer paths regardless.
Issue fork varbase_news_base-3620356
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshah