Problem/Motivation

The recipe.yml for the Educare site template lists the Search recipe (drupal_cms_search) before the five Varbase base recipes (Varbase Admin Base, Varbase Security Base, Varbase Media Base, Varbase Editor Base, Varbase Content Base) that build out the site's core content structure.

The Search recipe's own recipe.yml applies two wildcard config actions when it is applied:

  • node.type.* — sets a Search API Exclude third-party setting on every existing content type.
  • core.entity_view_display.node.*.default — cloned into node.%.search_index.

Both act only on content types that already exist at the moment Search is applied, so running Search before the Varbase base recipes means it wires up less of the site's eventual content structure than it could.

Steps to reproduce

  1. On the 1.0.x branch, open recipe.yml and note that drupal_cms_search is listed immediately after drupal_cms_accessibility_tools and before easy_email_express, that is, before varbase_admin_base, varbase_security_base, varbase_media_base, varbase_editor_base and varbase_content_base.
  2. Apply the Educare recipe (drush recipe recipes/educare, or install through the site template picker) and note that Search's wildcard config actions run before the Varbase base recipes, in particular Varbase Content Base, have finished.

Proposed resolution

Move drupal_cms_search in recipe.yml to apply after varbase_content_base, instead of before all of the Varbase base recipes.

This mirrors #3620223 on the Horizon Aid site template, which makes the same one-line move for the same reason. Educare's recipe.yml has the identical ordering.

What does not apply here

Horizon Aid's issue also cites a harder failure documented in its own CI: without the curated Drupal core patch for #2741429, a fresh install dies inside drupal_cms_search's display cloning with getConfigDependencyName() on null.

That half does not apply to Educare. Educare carries no vardot/drupal-core-patches wiring and no such comment in its .gitlab-ci.yml — the patches requirement and the Drupal CMS wiring script were removed in #3618244. So this issue rests on the wildcard-ordering argument alone, which is a property of the Search recipe itself and holds regardless.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • Search's wildcard actions see more of the site's content structure, so more content types get the Search API Exclude setting and the node.%.search_index view display clone at install time.

Release notes snippet

  • Apply the Search recipe after Varbase Content Base, so its wildcard config actions see the content types the Varbase base recipes create.

AI-Generated: Yes

Issue fork educare-3620242

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed cb3ea52b on 1.0.x
    task: #3620242 Move Search after Varbase Content Base in recipe.yml
    
rajab natshah’s picture

Assigned: Unassigned » josebc
Issue summary: View changes
Status: Active » Needs review
Issue tags: +educare-1.0.0-alpha3
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.