Problem/Motivation

It doesn't matter whether consent is given temporarily (by clicking the "Yes (this time)" button) or permanently ("Always").
Reloading does not help either.

This is because data-src is not replaced with src on the player iframe.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork videojs-3619293

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

thomas.frobieter created an issue. See original summary.

thomas.frobieter’s picture

Assigned: Unassigned » grevil

grevil made their first commit to this issue’s fork.

grevil’s picture

Assigned: grevil » Unassigned
Status: Active » Needs review

Fixed! Problem was, that the "data-name" was always "vimeo" when both klaro services where active, since both use the same query selector to set their data-name attribute.

grevil’s picture

Test failures are unrelated. I will fix 'em in a follow-up.

grevil’s picture

Status: Needs review » Reviewed & tested by the community

Talked with @thomas.frobieter internally and the class names are fine.

grevil’s picture

Status: Reviewed & tested by the community » Needs review
thomas.frobieter’s picture

Status: Needs review » Reviewed & tested by the community

LGTM! I'm so glad it was just such a simple problem 🙏

  • grevil committed 52b78149 on 10.x
    fix: #3619293 [10.x] Klaro integration: Remote video playback is not...
grevil’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.