Problem/Motivation

Autocomplete Deluxe has no automated functional testing, so every change is checked by hand. The widget is JavaScript heavy, which is exactly the kind of code that quietly breaks: the delimiter, the Backspace key, the suggestion list, the new term message and the save flow all live in the browser.

Steps to reproduce

  1. Change anything in the widget JavaScript.
  2. Nothing tells you which of the widget behaviours stopped working.

Proposed resolution

Add the same automated functional testing the sibling modules use: webship-js, which drives Playwright through Cucumber features, with a hidden test recipe that provisions the content type, the vocabulary and the field so the suite does not depend on what the install profile ships.

Twenty one scenarios: login, the taxonomy set up, the widget render, the stylesheet each admin theme gets, the suggestion list, multiple values, new terms disabled, the keyboard and the minimum length, the save flow, the help page, accessibility and a mobile breakpoint.

The Cucumber report of the suite run

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ✅ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ✅ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ➖ Reviewed by human
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Autocomplete Deluxe now ships an automated functional testing suite for the widget.
CommentFileSizeAuthor
#3 3619108-test-report.png55.28 KBrajab natshah
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new55.28 KB

The suite is up as a merge request of its own, split out of #3591908: Support Drupal 12 Default Admin (Gin-in-core) styling so the Drupal 12 styling and the tests are each their own review.

Ran it against Drupal 11.4: 20 scenarios and 114 steps pass on Claro, and the Gin cell passes with the Gin theme set as the admin theme, which is 21 of 21.

One thing the suite uncovered before it could run at all: package.json still lists farbtastic and joyride as GitHub tarballs that no longer exist, so a clean install fails. Both are dropped in the same merge request.

The Cucumber report of the suite run

To review, test, then merge.

  • rajab natshah committed 0371cb89 on 2.1.x
    test: #3619108 Add the browser test suite for the Autocomplete Deluxe...
rajab natshah’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Assigned: rajab natshah » Unassigned