Problem/Motivation
CI proves the Horizon Aid site template installs on a plain Drupal CMS base, but it never tests it. The 🧩 (Drupal CMS) Install Horizon Aid site template job builds drupal/cms, installs the template and asserts the default theme, then stops. Its only artifacts are cmssite/composer.json and cmssite/package.json, so there is no built site and no database dump for anything downstream to run against.
Meanwhile all 19 🧪 varbase-e2e buckets declare needs: ["📦 (Varbase) Install Horizon Aid site template"], so the whole functional suite only ever runs on the Varbase base. A regression that affects only the Drupal CMS base would pass CI today.
Steps to reproduce
- Open
.gitlab-ci.ymlon the1.0.xbranch. - The
🧪 varbase-e2ejob needs the Varbase install job only. - The Drupal CMS install job publishes no site and no database artifact, so no test job can consume it.
Proposed resolution
- In the Drupal CMS install job, dump the database and keep the built site, mirroring what the Varbase install job already does (it publishes
testsiteplus a gzippedhorizonaid-db.sql.gz). - Add one
🧪 varbase-e2e (Drupal CMS)job thatneedsthe Drupal CMS install job, restores that site and dump, serves it withdrush runserver, and runs a smoke subset of the feature suite:01-website-base-requirementsand07-quality. Not the full 19 bucket matrix, so the pipeline does not roughly double in cost. - Keep every job
allow_failure: false. Nothing masked. - If a feature fails because it genuinely does not apply on a plain Drupal CMS base (no Varbase profile), report the list rather than silently excluding it.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ❌ Publish the built site and a database dump from the Drupal CMS install job
- ❌ Add a Drupal CMS e2e job running the smoke subset
- ❌ Prove the new job green in a real pipeline
- ✅ Testing to ensure no regression
- ❌ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release, horizonaid-1.0.0-alpha2
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- The automated test suite now also runs against the Drupal CMS install in CI.
Issue fork horizonaid-3618301
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajab natshahComment #5
rajab natshahComment #6
rajab natshah✅ Released horizonaid-1.0.0-alpha2